[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #5810 [Stem]: Implement verification of server descriptor
#5810: Implement verification of server descriptor
-------------------------+--------------------------------------------------
Reporter: reganeet | Owner: reganeet
Type: enhancement | Status: new
Priority: normal | Milestone:
Component: Stem | Version:
Keywords: descriptors | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Comment(by eoinof):
I took a look at the problems in this ticket..
I've made an initial fix here.
https://github.com/eoinof/stem/commits/stem-trac-5810
It makes the code work 'properly' but does not fix the now
broken unit tests that relied on invalid relay descriptor data.
I implemented the signature verification both with the
python-rsa library[default] and also with the python-crypto library
though I had to write some custom code in both cases as neither
library appears to do exactly what was needed.
I can look into 'fixing' the unit tests insofar as necessary.
This is an example of the kind of hard coding that no longer passes.
{{{
Traceback:
File "/home/eoin/stem/test/integ/descriptor/server_descriptor.py", line
89, in test_metrics_descriptor
self.assertEquals("2C7B27BEAB04B4E2459D89CA6D5CD1CC5F95A689",
desc.digest())
AssertionError: '2C7B27BEAB04B4E2459D89CA6D5CD1CC5F95A689' !=
",{'\xbe\xab\x04\xb4\xe2E\x9d\x89\xcam\\\xd1\xcc_\x95\xa6\x89"
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5810#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs