[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9069 [Flashproxy]: Set have_websocket_binary_frames for Firefox

#9069: Set have_websocket_binary_frames for Firefox
----------------------------+----------------------------
     Reporter:  dcf         |      Owner:  dcf
         Type:  defect      |     Status:  needs_revision
     Priority:  normal      |  Milestone:
    Component:  Flashproxy  |    Version:
   Resolution:              |   Keywords:  easy
Actual Points:              |  Parent ID:
       Points:              |
----------------------------+----------------------------
Changes (by dcf):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:1 arlolra]:
 > Firefox 11 sure does.
 > https://developer.mozilla.org/en-US/docs/WebSockets
 >
 > Added a patch and tested on 10 / 11 to verify that it works on both.

 Could you split this into three separate patches?
  * One to refactor `have_websocket_binary_frames`,
  * One to add tests for `have_websocket_binary_frames`,
  * One to add Firefox 11 to `have_websocket_binary_frames`.
 What I do is generate three patches with `git format-patch HEAD^^^` and
 then `cat` them together so they can be applied with `git am`.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9069#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs