[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13439 [Tor Browser]: Inspector raises the canvas prompt when hovering over images

#13439: Inspector raises the canvas prompt when hovering over images
-----------------------------+-------------------------------------
     Reporter:  dcf          |      Owner:  tbb-team
         Type:  defect       |     Status:  new
     Priority:  minor        |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:  tbb-easy, tbb-usability
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-------------------------------------

Comment (by gacar):

 There was already a check for exempting `file://` URLs from canvas prompt
 in  [https://gitweb.torproject.org/tor-browser.git/blob/refs/heads/tor-
 browser-31.2.0esr-4.5-1:/content/canvas/src/CanvasUtils.cpp#l68
 `IsImageExtractionAllowed()`]. The above patch adds `resource://` URLs to
 this exemption.

 The patch should prevent prompts due to the Inspector and PDF.js, but I
 haven't had the chance to test it.

 I also agree that having this check as a separate function (e.g.
 `IsURLExemptFromCanvas()`) is a better idea.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13439#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs