[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #13827 [Tor]: Cell handling code duplication in channel.c

#13827: Cell handling code duplication in channel.c
------------------------------+----------------------------------
 Reporter:  rl1987            |          Owner:
     Type:  defect            |         Status:  new
 Priority:  normal            |      Milestone:  Tor: unspecified
Component:  Tor               |        Version:
 Keywords:  refactoring easy  |  Actual Points:
Parent ID:                    |         Points:
------------------------------+----------------------------------
 In 336c856e52d211aad6b40d29986264f3277a1327 :

  * `channel_get_var_cell_handler()` and `channel_get_cell_handler() `looks
 very similar
  * `channel_write_cell()`, `channel_write_packed_cell()` and
 `channel_write_var_cell()` is mostly duplicated code.
  * so are `channel_queue_cell()` and `channel_queue_var_cell()`

 We should refactor to reduce the code duplication.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13827>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs