[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13818 [Tor Browser]: [PATCH] Active tab looks ugly (inherits system color scheme only partially)

#13818: [PATCH] Active tab looks ugly (inherits system color scheme only partially)
-----------------------------+-----------------------------------
     Reporter:  gentoo_root  |      Owner:  tbb-team
         Type:  defect       |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:  TorBrowserTeam201411R
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------------------------

Comment (by mcs):

 Our tests so far show that a remote page that loads a chrome:// SVG will
 not be able to access the DOM (which should mean that it cannot access the
 rendered colors of elements within the SVG).  The SVG image loads OK with
 an <img> tag but the same origin policy blocks loading via tags such as
 iframe and object.  So maybe the original patch is safe.

 We could also try checking nsContentUtils::IsCallerChrome() instead of
 aPresContext->IsChrome().  It bothers me that I cannot remember why we did
 not use that kind of check in the original patch for #6786.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13818#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs