[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12651 [Onionoo]: Details documents of non-running nodes may contain "running":true

#12651: Details documents of non-running nodes may contain "running":true
-------------------------+--------------------------
     Reporter:  karsten  |      Owner:  karsten
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:
    Component:  Onionoo  |    Version:
   Resolution:           |   Keywords:
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------

Comment (by karsten):

 I finally found some time to rebase my branch to master:
 https://gitweb.torproject.org/user/karsten/onionoo.git/shortlog/refs/heads/task-12651-3.
 It has three commits:
  - 09d7774 should be ''very'' similar to the commit you reviewed in
 task-12651-2.  (Maybe confirm that by comparing commits.)
  - e789855 is pretty big, but it greatly simplifies current complexity
 between node statuses and details statuses.  It's also an important
 improvement towards supporting bulk imports better.
  - 61817b9 is an attempt to unit-test the changes in e789855, but it's not
 finished.

 Would you want to take a look at this branch and maybe even complete the
 unit tests?

 I'm starting some local test runs now.  If nothing breaks horribly, I
 might feel brave enough to deploy the branch on the mirror later this
 week.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12651#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs