Re: [tor-bugs] #17568 [Tor Browser]: Clean up tor-control-port.js in Torbutton

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#17568: Clean up tor-control-port.js in Torbutton
---------------------------+--------------------------
 Reporter:  gk             |          Owner:  tbb-team
     Type:  task           |         Status:  new
 Priority:  Medium         |      Milestone:
Component:  Tor Browser    |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:  tbb-torbutton  |  Actual Points:
Parent ID:                 |         Points:
  Sponsor:                 |
---------------------------+--------------------------

Comment (by gk):

 {{{
   // matchResult finds a single-line result for `250-` or a multi-line one
 for `250+`.
 }}}
 is interesting as you are not mentioning the `250 ` case although your
 regex is checking for it. But I think the comment is right here (but not
 the code) as the `250 ` case should not make it that far as I guess
 `EndReplyLine` does not contain a `=` (see the `250 Bridge` example) and
 `key` would therefore be `null`. That's one of the things I still need to
 figure out which is a bit tricky as `ReplyText` is not specified in the
 spec.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17568#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs