Re: [tor-bugs] #17446 [Tor Browser]: Canvas image extraction prompt logic

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#17446: Canvas image extraction prompt logic
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  Medium                               |         Status:
Component:  Tor Browser                          |  needs_revision
 Severity:  Normal                               |      Milestone:
 Keywords:  tbb-fingerprinting,                  |        Version:
  PearlCrescent201511R, TorBrowserTeam201511R    |     Resolution:
Parent ID:                                       |  Actual Points:
  Sponsor:                                       |         Points:
-------------------------------------------------+-------------------------

Comment (by gk):

 While we are at it (I have not checked the whole patch yet):

 1) Your new patch has added a newline right at the beginning of the file

 2) We have
 {{{
   if (!aDocument || !aCx)
     return false;

   nsPIDOMWindow *win = aDocument->GetWindow();
 }}}
 which basically assumes we'll always have a document as otherwise
 `aDocument->GetWindow()` would blow up. Why do we have the `!aCx` check
 then at all?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17446#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs