[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17632 [Tor]: Tor unit tests fail on FreeBSD IPv6-only
#17632: Tor unit tests fail on FreeBSD IPv6-only
--------------------+------------------------------------
Reporter: teor | Owner:
Type: defect | Status: needs_review
Priority: Medium | Milestone: Tor: 0.2.7.x-final
Component: Tor | Version: Tor: 0.2.7.4-rc
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Sponsor: |
--------------------+------------------------------------
Changes (by teor):
* status: new => needs_review
* version: => Tor: 0.2.7.4-rc
* milestone: => Tor: 0.2.7.x-final
Comment:
Please see my branch bug17632-no-ipv4-no-localhost-squashed on
https://github.com/teor2345/tor.git
Given this is a unit test fix for issues in 0.2.7.3-rc, do we need to
backport it to 0.2.7?
This patch makes unit tests pass on IPv6-only systems, and systems without
localhost addresses (like some FreeBSD jails). It also modifies a comment
in get_interface_addresses_ioctl to cover some obscure platforms.
It's a bugfix on unit tests first released in 0.2.7.3-rc. #17255 merged
c464a367728d as a partial fix for this issue, it was released in unit
tests in 0.2.7.4-rc.
Fixes:
* get_if_addrs_ifaddrs: systems without localhost
* get_if_addrs_ioctl: only works on IPv4 systems
* socket: check IPv4 and IPv6, skip on EPROTONOSUPPORT
* socketpair_ersatz: uses IPv4, skip on EPROTONOSUPPORT
I've tested this on:
* OS X IPv4 / IPv6 (tunnel)
* OS X IPv4-only
* OS X IPv6-only
* OS X no interfaces (before and after destroying bridge0 and gif0)
* Linux IPv4-only
* FreeBSD IPv6-only (jail - no IPv6 or IPv4 localhost)
I have another test system, but I can't seem to get git working on it:
* Linux IPv6-only (IPv4 localhost)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17632#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs