[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #13737 [Tor]: Implement circuit building crypto to worker
#13737: Implement circuit building crypto to worker
-------------------------------------------------+-------------------------
Reporter: dgoulet | Owner:
Type: enhancement | Status:
Priority: Medium | needs_review
Component: Tor | Milestone: Tor:
Severity: Normal | 0.2.???
Keywords: tor-client, tor-hs, multicore, | Version: Tor:
performance, 027-triaged-1-in | 0.2.7
Parent ID: | Resolution:
Sponsor: | Actual Points:
| Points: small-
| remaning
-------------------------------------------------+-------------------------
Comment (by dgoulet):
Here is the _only_ thing I found (typo) :)
* Comment here should be REPLY instead of "RESPONSE".
{{{
+ /** Magic number; must be CPUWORKER_[type]_[REQUEST,RESPONSE]_MAGIC. */
}}}
The rest lgtm. I have to agree that there is a lot of code duplication
here but I'm also OK with having server/client seperate here even though
it's almost the same.
I'm also not super fan of having this `++total_pending_tasks;` done
_before_ we actually successfully queue the task but I think that was in
before this patch anyway (and highly unlikely also...).
Good work here!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13737#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs