[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17242 [Tor]: Implement client and service support for proposal 224
#17242: Implement client and service support for proposal 224
-------------------------+------------------------------
Reporter: dgoulet | Owner:
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor: 0.2.???
Component: Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs | Actual Points:
Parent ID: #12424 | Points: large
Sponsor: |
-------------------------+------------------------------
Changes (by teor):
* status: new => needs_review
Comment:
Replying to [comment:7 nickm]:
> Merged, but one thing:
>
> Should the H(salt) you added be H("derive-salt" | salt) ?
(93f47f4f4e7614d4b3debfe9b5f3a22bfe5d64b1)
Since the input is random, ioerror thinks that a distinguishing value is
unnecessary, and I tend to agree. I think it also has performance
implications if we are hashing more than 256 bits into a 256 bit hash.
>
> And should it be explicitly said that it's truncated to 16 bytes?
Yes, let's make that clear.
I've pushed fixups to rend-ng-descriptors on my github.
They're based on the last commit in the series to modify the relevant part
of the spec, so they should fixup cleanly.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17242#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs