[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17254 [Tor]: Scalable HSes by splitting intro/rendezvous

#17254: Scalable HSes by splitting intro/rendezvous
-------------------------+------------------------------------
 Reporter:  TvdW         |          Owner:
     Type:  enhancement  |         Status:  needs_revision
 Priority:  High         |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor          |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:  tor-hs       |  Actual Points:
Parent ID:               |         Points:  medium
  Sponsor:  SponsorR     |
-------------------------+------------------------------------

Comment (by asn):

 Replying to [comment:18 TvdW]:
 > I just pushed a new branch, now with the decryption done before the
 handoff, and the event renamed to INTRODUCE_HANDOFF. The blob logic is now
 moved to Trunnel.
 >
 > https://github.com/TvdW/tor/commits/split-hs-intro-rend-v2
 >
 > Spec branch will follow soon. Code branch still lacks tests (Sorry!)
 >
 >
 > @teor: I had a look at rend_service_relaunch_rendezvous. Looks like no
 change is needed, as rend_service_perform_rendezvous sets up the internal
 structures correctly.

 Very nice!

 I took a small peak at the code, and it looks nice!

 Here are some things that crossed my mind in this initial review:

 - Some places are lacking documentation. e.g.
 `rend_service_handoff_introduce()`

 - It would be really great if there was some unittest that verified the
 correctness of the handoff-then-perform procedure.

 - As you noted with your XXX, in case of perform failure it would be
 better if we send a 550 or 551 control failure instead of
 `send_control_done(conn)`.

 - `uint8_t buffer[2048];` I wonder if this stack buffer needs to be so
 big. Or maybe this is premature optimization and we should just move on.

 Will review more seriously after the spec branch is also updated!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17254#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs