[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17254 [Tor]: Scalable HSes by splitting intro/rendezvous

#17254: Scalable HSes by splitting intro/rendezvous
-------------------------+------------------------------------
 Reporter:  TvdW         |          Owner:
     Type:  enhancement  |         Status:  needs_revision
 Priority:  High         |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor          |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:  tor-hs       |  Actual Points:
Parent ID:               |         Points:  medium
  Sponsor:  SponsorR     |
-------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:21 TvdW]:
 > > - It would be really great if there was some unittest that verified
 the correctness of the handoff-then-perform procedure.
 >
 > Haven't figured out how to do this yet :-( I suppose I could make
 `rend_service_perform_rendezvous()` mock-able, and then call the
 `rend_service_handoff_introduce()`/`handle_control_perform_rendezvous()`
 combo. That wouldn't really test the behavior though, which is something I
 think only Chutney could test.

 If I understand correctly, the unit test you suggest sounds useful to make
 sure that rend_service_perform_rendezvous() still behaves like it used to.
 That's an important property.

 But it would also be useful to have a unit test that synthetically
 performs a handoff by acting like a fake controller:
 * calls rend_service_perform_rendezvous() with "real" encrypted rendezvous
 response data
 * by mocking rend_service_handoff_introduce() or similar:
   * takes the parameters that would be in the control event
   * manually sends those parameters through
 handle_control_perform_rendezvous()
 * checks that the resulting actions and state are as expected, probably by
 mocking functions called by handle_control_perform_rendezvous()

 (Or is this what you're suggesting?)

 This will help us make sure we don't accidentally break rendezvous handoff
 as we refactor the hidden service code for prop224.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17254#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs