[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17617 [metrics-lib]: Parse flag thresholds and provide them as double values in BridgeNetworkStatus and RelayNetworkStatusVote
#17617: Parse flag thresholds and provide them as double values in
BridgeNetworkStatus and RelayNetworkStatusVote
-------------------------+------------------------------
Reporter: karsten | Owner: karsten
Type: enhancement | Status: needs_review
Priority: Medium | Milestone:
Component: metrics-lib | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Sponsor: |
-------------------------+------------------------------
Comment (by iwakeh):
Why not make the newly added method comments javadoc?
And, maybe verify the other comments in the same interface and make them
javacoc, too?
Would be a start for the javadoc issue.
In addition, metrics-lib should actually upgrade to java 7.
[https://www.oracle.com/technetwork/java/javase/downloads/java-archive-
downloads-javase6-419409.html Oracle.com]
{{{
WARNING: These older versions of the JRE and JDK are provided to help
developers debug issues in
older systems. They are not updated with the latest security patches and
are not recommended for use
in production.
...
}}}
It's really outdated by now (onionoo also uses 7) and the timing with the
first release would be right.
It could also avoid the endless if-else-if statements using string
switches.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17617#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs