Re: [tor-bugs] #13696 [Tor]: Use syscall-based entropy reading where possible.

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#13696: Use syscall-based entropy reading where possible.
-------------------------+--------------------------------
 Reporter:  nickm        |          Owner:  yawning
     Type:  enhancement  |         Status:  needs_revision
 Priority:  Medium       |      Milestone:  Tor: 0.2.???
Component:  Tor          |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:  tor-relay    |  Actual Points:
Parent ID:               |         Points:
  Sponsor:               |
-------------------------+--------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 * Have any other bsds grabbed getentropy() ?  Possibly we should check for
 it with autoconf rather than with #if directives.
  * A part of me says that it would be smart to 0-fill the buffer before we
 call these functions, and then verify that they actually filled the buffer
 with something other than 0s. (Assuming that the buffer is of sufficient
 size)
  * Maybe a comment should document what the 0 flags mean here.
  * I don't think that a warn should be necessary if getrandom() returns
 ENOSYS.
  * If we're doing `tor_assert(ret == (int)out_len);`, should we check for
 out_len rather than -1 in the loop?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13696#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs