[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17638 [Tor]: Make ersatz_socketpair work on IPv6-only systems:

#17638: Make ersatz_socketpair work on IPv6-only systems:
-----------------------------------------+---------------------------------
 Reporter:  teor                         |          Owner:
     Type:  defect                       |         Status:  closed
 Priority:  Medium                       |      Milestone:  Tor:
Component:  Tor                          |  0.2.8.x-final
 Severity:  Normal                       |        Version:  Tor:
 Keywords:  easy ipv6 TorCoreTeam201511  |  unspecified
Parent ID:                               |     Resolution:  fixed
  Sponsor:                               |  Actual Points:
                                         |         Points:
-----------------------------------------+---------------------------------
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 For 0001, why not just change the type to uint16_t ?  Did that in
 a45aacd2e292ea0522313e430e5ff8c70fadf8f7.

 The patch 0002 adds a signed/unsigned comparison on systems where
 socklen_t is _unsigned_.  Tried a different approach as
 f108be7c2556de20dc34c0a8ad52b19c363febbd.

 Also, I really don't like jamming this stuff into a sockaddr;
 sockaddr_storage is the one that's guaranteed to work.  Tried to fix that
 in eedef419445098dbce1b25e782bbe023bc659902.

 Please reopen if I messed up.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17638#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs