[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17701 [metrics-lib]: ExitList descriptor chokes on getUnrecognizedLines()
#17701: ExitList descriptor chokes on getUnrecognizedLines()
-------------------------+-------------------------
Reporter: tomlurge | Owner: karsten
Type: defect | Status: new
Priority: Medium | Milestone:
Component: metrics-lib | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Sponsor: |
-------------------------+-------------------------
Comment (by iwakeh):
Replying to [comment:15 tomlurge]:
> But still this is a bug, right? The converter is not supposed to just
give up silently on a whole descriptor file just because it encounters an
empty entry.
>
>
No, it seems to be a feature. The descriptor doesn't give up silently,
because there is the
getException() method. The Converter ought to use it in order to find out
about problems.
That's why it's there.
And, that processing ends here was a decision made by Karsten long ago, so
he probably could
tell about the reasoning behind it.
Ceterum censeo ;-) these findings are even more reason to add tests for
the Converter now
and define expected behavior.
> Btw: it's not a "double" entry as you say. It's an empty entry, followed
by the next, non-empty, entry. So it's 2 ExitAddress lines following each
other immediatly, but with different content.
This is not my naming:
The metrics-lib code expects one ExitAddress and then the three other data
lines,
but it encounters two ExitNode entries. Thus, the metrics-lib code
'thinks' this a duplicate ExitNode entry in one descriptor.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17701#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs