Re: [tor-bugs] #17306 [Core Tor/Stem]: Split up controller.py's integ tests

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#17306: Split up controller.py's integ tests
---------------------------+------------------------
 Reporter:  atagar         |          Owner:  atagar
     Type:  enhancement    |         Status:  new
 Priority:  Low            |      Milestone:
Component:  Core Tor/Stem  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:  testing, easy  |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------

Comment (by atagar):

 Thanks Neel! This ticket is pretty old and since then I've had time to
 think about a good alternate way to structure our tests. Rather than
 breaking up test functions think we should aim for the test modules so
 they relate to a single class or topic. That is to say instead of...

 {{{
 class TestController(unittest.TestCase):
   ... tests everything...
 }}}

 ... we have...

 {{{
 class TestControllerCommands(unittest.TestCase):
   ... tests GETINFO, GETCONF, etc...

 class TestHiddenServices(unittest.TestCase):
   ... tests hidden service functions...
 }}}

 There could be merit to breaking up the functions as you did here too.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17306#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs