Re: [tor-bugs] #19459 [Applications/Tor Browser]: Write (C++) patch for window resizing parts

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#19459: Write (C++) patch for window resizing parts
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton-conversion,            |  Actual Points:
  TorBrowserTeam201610R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------

Comment (by mcs):

 Replying to [comment:39 arthuredelstein]:
 > I have added two prefs: privacy.window.maxInnerWidth and
 privacy.window.maxInnerHeight. Hopefully these will be enough to solve any
 such problems.

 Kathy and I were actually more concerned about removal of
 `extensions.torbutton.window.innerWidth` / `innerHeight`. Without those
 prefs, there should be no way to get a window that is wider than 1000
 pixels at startup, for example. I guess someone needs to make the call on
 whether it is okay to remove this functionality.

 > Here's the new version:
 >
 > https://github.com/arthuredelstein/tor-browser/commit/19459+14
 > https://github.com/arthuredelstein/torbutton/commit/19459+1

 The changes looked okay to Kathy and me, but when we tested on a Retina
 Mac with Sierra (OSX 10.12.1), we saw incorrect results (content window
 size was 1300 x 700 at startup). Here is the output from the
 `nsXULWindow::ResizeToRoundedDimensions()` printf logging:
 {{{
 scaling factor: 2.000000
 window size: 2000 x 1558
 avail screen size: 2880 x 1746
 primary content shell: 200 x 200
 target content size: 800, 200

 window size: 2600 x 1558
 avail screen size: 1440 x 873
 primary content shell: 200 x 200
 }}}
 (notice the `primary content shell` output). If we comment out the call to
 quantizeBrowserSize() inside torbutton.js, the output looks correct (and
 the content window size is 1000 x 700):
 {{{
 scaling factor: 2.000000
 window size: 2400 x 1604
 avail screen size: 2880 x 1746
 primary content shell: 2400 x 1400
 target content size: 2000, 1400

 window size: 2000 x 1604
 avail screen size: 1440 x 873
 primary content shell: 2000 x 1400
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19459#comment:40>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs