[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20509 [Core Tor/Tor]: Directory authorities should take away Guard flag from relays with #20499 bug

#20509: Directory authorities should take away Guard flag from relays with #20499
bug
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.9.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  028-backport, easy,                  |  Actual Points:
  TorCoreTeam201611                              |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Thanks!
 This looks almost ready to go.

 But please make:
 {{{
 tor_version_parse("Tor 0.3.0.0-alpha-dev", &bad)
 }}}
 a separate statement with an appropriate comment. It's confusing to put it
 with the other check. Also, if "Tor 0.3.0.0-alpha-dev" fails to parse,
 that's a coding bug. So you could do something like:
 {{{
 /* We should always be able to parse this version string */
 if (BUG(tor_version_parse("Tor 0.3.0.0-alpha-dev", &bad) == -1)) {
   return 0;
 }
 }}}

 Nitpick:

 I was confused what `cur` and `bad` meant. We could use longer names for
 them. I'd like to try to make it clearer that `cur` is the parsed form of
 `platform`; and that `bad` isn't the only bad version, and it is the
 parsed form of "Tor 0.3.0.0-alpha-dev".

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20509#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs