[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20587 [Core Tor/Tor]: Limit next_attempt_overflow to TIME_MAX, not INT_MAX

#20587: Limit next_attempt_overflow to TIME_MAX, not INT_MAX
-------------------------------+------------------------------------
 Reporter:  nickm              |          Owner:  nickm
     Type:  defect             |         Status:  needs_revision
 Priority:  Medium             |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor       |        Version:  Tor: 0.2.8.1-alpha
 Severity:  Normal             |     Resolution:
 Keywords:  CoreTorTeam201611  |  Actual Points:  0
Parent ID:                     |         Points:  0
 Reviewer:                     |        Sponsor:
-------------------------------+------------------------------------
Changes (by teor):

 * keywords:   => CoreTorTeam201611
 * status:  needs_review => needs_revision
 * version:   => Tor: 0.2.8.1-alpha


Comment:

 Looks good to me.

 I am concerned we didn't have a unit test that would pick this up. We
 should probably add one to test_dir_download_status_schedule().

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20587#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs