[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19553 [Metrics/Atlas]: Do not plot empty graphs



#19553: Do not plot empty graphs
---------------------------+-----------------------------------
 Reporter:  twim           |          Owner:
     Type:  defect         |         Status:  needs_information
 Priority:  Medium         |      Milestone:
Component:  Metrics/Atlas  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+-----------------------------------

Comment (by twim):

 Replying to [comment:12 karsten]:
 > Replying to [comment:10 iwakeh]:
 > > I think the "No data available" shouldn't be displayed, the graphs
 should just be omitted.
 >
 > Plausible.  After all, this is JavaScript, where we can do such magical
 things like making parts of the page disappear.

 Agreed. Atlas should just draw what is available from Onionoo data. Just
 as simple as that.

 Actually I've implemented hiding of empty graphs on top of my patch in
 this ticket. I don't quite remember details (it was long ago) but this may
 be useful. The corresponding code seems to be in commit
 6c41495e80b99059b7605279a40be3f53a4845f6 at
 https://github.com/nogoegst/atlas.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19553#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs