[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20521 [Metrics/metrics-lib]: Deprecate `DescriptorReader.setExcludeFiles()` and add two separate methods for loading and saving a history file

#20521: Deprecate `DescriptorReader.setExcludeFiles()` and add two separate methods
for loading and saving a history file
---------------------------------+-----------------------------------
 Reporter:  karsten              |          Owner:  karsten
     Type:  enhancement          |         Status:  needs_review
 Priority:  Medium               |      Milestone:  metrics-lib 1.6.0
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+-----------------------------------

Comment (by iwakeh):

 Please find a [https://gitweb.torproject.org/user/iwakeh/metrics-
 lib.git/commit/?h=task-20521-2&id=c8707e56904119fc072b700b9f839ac371c1d83e
 commit] on top of your branch with some modernization (reduced number of
 lines) and a checkstyle complaint removed.

 Wouldn't this be the right time to add a test class for
 `DescriptorReader`(Impl)?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20521#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs