Re: [tor-bugs] #20568 [Core Tor/Tor]: Move encode_cert() from hs_descriptor.c into torcert.c

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#20568: Move encode_cert() from hs_descriptor.c into torcert.c
---------------------------------------+-----------------------------------
 Reporter:  dgoulet                    |          Owner:
     Type:  enhancement                |         Status:  needs_revision
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.3.0.x-final
Component:  Core Tor/Tor               |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  tor-hs, easy, refactoring  |  Actual Points:
Parent ID:                             |         Points:  0.1
 Reviewer:                             |        Sponsor:  SponsorR-can
---------------------------------------+-----------------------------------
Changes (by dgoulet):

 * status:  new => needs_revision


Comment:

 Thanks for this neel!

 * DG1: I would rename the function to something more meaningful as this
 function encoded an ed25519 certificate which is pretty specific and also
 should follow the torcert.c namespace. Maybe `tor_cert_encode_ed22519()` ?

 * DG2: You can remove it from `hs_descriptor.h` instead of commenting it
 out.

 * DG3: We have to change this log message to be a bit more generic as it's
 very specific to HS right now.
 {{{
     log_err(LD_BUG, "Couldn't base64-encode descriptor signing key
 cert!");
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20568#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs