[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20629 [Core Tor/Tor]: hs: Fix issues found by coverity
#20629: hs: Fix issues found by coverity
-----------------------------+------------------------------------
Reporter: dgoulet | Owner: dgoulet
Type: defect | Status: merge_ready
Priority: Medium | Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs, prop224 | Actual Points:
Parent ID: | Points: 0.1
Reviewer: | Sponsor: SponsorR-must
-----------------------------+------------------------------------
Changes (by dgoulet):
* status: new => merge_ready
Comment:
See branch: `bug20629_030_01`. Going in merge_ready mode here because the
fix is trivial and hopefully makes coverity happy.
For completion, here is what coverity was complaining about:
{{{
>>> CID 1375998: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "chunked_desc" suggests that it may be null, but it
has already been dereferenced on all paths leading to the check.
1391 if (chunked_desc) {
1392 SMARTLIST_FOREACH(chunked_desc, char *, a, tor_free(a));
1393 smartlist_free(chunked_desc);
1394 }
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20629#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs