[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20632 [Core Tor/Tor]: Fix error handling in rend_service_parse_port_config()

#20632: Fix error handling in rend_service_parse_port_config()
--------------------------+------------------------------------
 Reporter:  twim          |          Owner:
     Type:  defect        |         Status:  merge_ready
 Priority:  Low           |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-hs        |  Actual Points:
Parent ID:                |         Points:  0.1
 Reviewer:  dgoulet       |        Sponsor:  SponsorR-can
--------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * points:   => 0.1
 * sponsor:   => SponsorR-can
 * milestone:   => Tor: 0.3.0.x-final
 * keywords:   => tor-hs
 * reviewer:   => dgoulet


Comment:

 That makes the function do extra work when `err_msg_out` is NULL but tbh
 I'm fine with it as this function is not called often.

 lgtm;

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20632#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs