Re: [tor-bugs] #20668 [Metrics/Onionoo]: make test-sources comply to checkstyle

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#20668: make test-sources comply to checkstyle
-----------------------------+-----------------------------------
 Reporter:  iwakeh           |          Owner:  iwakeh
     Type:  enhancement      |         Status:  merge_ready
 Priority:  Medium           |      Milestone:  Onionoo 3.1-1.0.0
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+-----------------------------------
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:3 karsten]:
 > Looks great, thanks for putting the effort into that!
 >
 > I made one tiny change by reducing the maximum line length to 80 instead
 of 81 (from previously 100).

 For some reason I thought lines should be strictly less than the given
 number, but 80 is what was intended.

 > Should we adapt that in the other code bases, too?

 I think, you changed that for CollecTor.  And, the others don't have
 (many) tests ;-)  Adapt them when it's their turn.

 >
 > Oh, and we should mention that change in the header of that file.  I can
 do that.

 Great, thanks!

 Ready for merge.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20668#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs