[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19259 [Metrics/Onionoo]: uncaught NFE and other bugs in weight status document processing
#19259: uncaught NFE and other bugs in weight status document processing
-----------------------------+-----------------------------------
Reporter: iwakeh | Owner: iwakeh
Type: defect | Status: needs_review
Priority: High | Milestone: Onionoo 3.1-1.0.0
Component: Metrics/Onionoo | Version:
Severity: Major | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+-----------------------------------
Comment (by karsten):
Replying to [comment:19 iwakeh]:
> Please find
[https://gitweb.torproject.org/user/iwakeh/onionoo.git?h=task-19259 my
branch] for review.
>
> It has four commits on top of the current master. Two tweaking the
build environment, one for the tests and another for making the new tests
pass.
Looks good. I made a few tweaks in fixup commits in
[https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=task-19259
my task-19259 branch]. Please take a look, and if you like them, I'll
squash them into yours.
> One question: Should negative values still be recognized as missing
values (cf. comment:15)?
Uhhhhhm, do you mind rephrasing that question and giving a bit more
context? I could re-read the comments above, but maybe you can explain
this in 2 or 3 sentences? Thanks!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19259#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs