[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20634 [Core Tor/Tor]: Unit test address/get_if_addrs6_list_no_internal should succeed if there are only internal addresses

#20634: Unit test address/get_if_addrs6_list_no_internal should succeed if there
are only internal addresses
-----------------------------+------------------------------------
 Reporter:  teor             |          Owner:
     Type:  defect           |         Status:  needs_review
 Priority:  Medium           |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor     |        Version:  Tor: 0.2.8.1-alpha
 Severity:  Normal           |     Resolution:
 Keywords:  easy intro test  |  Actual Points:
Parent ID:                   |         Points:  0.1
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 Ok, I added a fixup commit for typos, whitespace, and line length; and a
 changes file, then I put it on a branch on github:
 https://github.com/teor2345/tor/commits/bug20634_029

 Our coding standards about whitespace, line length, and changes files are
 in:
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandards.md

 For whitespace and line length, I usually just run our automated check:
 `make check-spaces`

 If you're happy with the fixup and the changes file, let me know, and I
 will put the branch on the merge queue.

 Thanks for helping out!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20634#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs