Re: [tor-bugs] #20596 [Metrics]: add jdk version to manifest files

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#20596: add jdk version to manifest files
-------------------------+------------------------------
 Reporter:  iwakeh       |          Owner:  metrics-team
     Type:  enhancement  |         Status:  needs_review
 Priority:  Medium       |      Milestone:
Component:  Metrics      |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
-------------------------+------------------------------

Comment (by karsten):

 Ah, I didn't mean only the checkstyle parts but also the build.xml parts
 above.  Anyway, let's focus on checkstyle for the moment.

 Looking at the checkstyle commits I noticed that even those two don't
 contain the exact same output.  And we're still missing three more
 (Onionoo, Metrics website, and ExoneraTor).  How about we work on one
 checkstyle file for one code base, and once that's good, we copy that over
 to the others?

 Quick question: Why add two modules `SuppressWarningsFilter` and
 `SuppressWarningsHolder`?  Those are not explained in the changes section.
 Do we need both, and why?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20596#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs