[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20695 [Metrics/CollecTor]: handle json reading exception instead of escalating
#20695: handle json reading exception instead of escalating
-------------------------------+---------------------------------
Reporter: iwakeh | Owner: iwakeh
Type: defect | Status: closed
Priority: Medium | Milestone: CollecTor 1.2.0
Component: Metrics/CollecTor | Version:
Severity: Normal | Resolution: fixed
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------+---------------------------------
Changes (by iwakeh):
* status: needs_information => closed
* resolution: => fixed
Comment:
Replying to [comment:3 karsten]:
> ..
> > The argument free constructor for was necessary on order to prevent
the following complaint from Gson: `Unable to invoke no-args constructor
for class org.torproject.collector.relaydescs.ReferenceChecker$Reference.`
> > (I don't know why this didn't cause a problem elsewhere. I'm using
the libs distributed with release 1.1.0)
>
> Hmm? I didn't look at the code here. Does this need any fixing?
No, it is fixed in
[https://gitweb.torproject.org/user/iwakeh/collector.git/tree/src/main/java/org/torproject/collector/relaydescs/ReferenceChecker.java?h=task-20695&id=b71d83bc49bf6a6e28f52327e8bd879042998a74#n106
line 106 of ReferenceChecker]. Probably showed up in the new tests for
the very first time.
>
> > Also add this to milestone 1.2.0. Shouldn't the already released
milestones be closed?
>
> There, you should now be able to create or modify milestones. Want to
try closing the ones that can be closed?
Thanks :-)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20695#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs