[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20710 [Core Tor/Tor]: memory leak in sandbox_getaddrinfo()

#20710: memory leak in sandbox_getaddrinfo()
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.5.5-alpha
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by arma):

 Agreed.

 Now, is this just a memory leak, or is that old
 cached_getaddrinfo_item_free() dangerous in some way?

 That is, can we convince ourselves that when it does
 {{{
     *elm = (*elm)->field.hte_next;                                      \
 }}}
 inside HT_NEXT_RMV, *elm isn't dangerous to try to free?

 Fortunately, sandbox_free_getaddrinfo_cache() is only called on fork and
 on shutdown.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20710#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs