[tor-bugs] #24119 [Core Tor/Tor]: channel_rsa_id_group_set_badness spends a lot of time in malloc/free

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#24119: channel_rsa_id_group_set_badness spends a lot of time in malloc/free
------------------------------+--------------------------------
     Reporter:  Hello71       |      Owner:  (none)
         Type:  enhancement   |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.3.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Minor         |   Keywords:
Actual Points:                |  Parent ID:  #23777
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 in particular, a very large proportion (~25%) of allocations made seem to
 be "temporary", i.e. an allocation is made and then freed before any other
 allocations are made. possibly a portion of these are due to the second
 loop, but I was wondering if it is possible that the function is called
 with an empty list, and if that is a problem.

 regardless, I have written a patch to use ht instead of only smartlists,
 which should very slightly increase the memory usage and moderately
 decrease the CPU usage in this function.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24119>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs