Re: [tor-bugs] #23817 [Core Tor/Tor]: Tor re-tries directory mirrors that it knows are missing microdescriptors

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#23817: Tor re-tries directory mirrors that it knows are missing microdescriptors
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-guard, tor-hs, prop224,          |  Actual Points:
  032-backport? 031-backport? spec-change        |
Parent ID:  #21969                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * cc: teor (added)


Comment:

 Quick notes, not comprehensive:
   * The changes file doesn't say which version this is a bugfix on. (Does
 "make check" pass?)
   * Should this be a backport candidate for any earlier versions?
   * It looks like the first two commits on this branch are actually part
 of #23862, and already merged into 0.3.2?
   * Minor: The `relay_digest` argument to dir_microdesc_download_failed()
 would be better named "dir_id" or something, since it's the identity of
 the failing directory server?
   * Digestmap_t would be a better type to use for outdated_dirserver_list,
 but we can fix that later if need be.
   * Should entries on outdated_dirserver_list expire after some amount of
 time, in addition to just "whenever we get the next consensus?"
   * I wonder if we can think of a better name for this than "outdated
 dirserver" -- it's not outdated itself -- it just failed to give us
 microdescriptors for some consensus we had.
   * Do we check to make sure that the consensus is fairly recent before
 marking a dirserver as "outdated" in this way?
   * Maybe we should make sure that we never mark an authority as outdated?

 Adding teor in cc -- asn asked if you could review this patch too.  I'd
 like to merge it in the alpha coming out in a couple of days, if possible,
 though I understand you might not be able to review on that schedule.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23817#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs