[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23816 [Core Tor/Tor]: Use exponential backoff with jitter and/or tune its parameters

#23816: Use exponential backoff with jitter and/or tune its parameters
-----------------------------+------------------------------------
 Reporter:  nickm            |          Owner:  nickm
     Type:  defect           |         Status:  merge_ready
 Priority:  Medium           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-24  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  catalyst         |        Sponsor:  SponsorV
-----------------------------+------------------------------------
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Thanks!  The updated patches look good to me.  There are few minor nits
 with spacing around operators (e.g., `INT_MAX/3`, `base_delay+1`,
 `low_bound=0, high_bound=max_delay`) that you may wish to fix before
 merging, but they're probably not worth another round of review.

 I wrote some rough simulations in Python and they do show a significant
 improvement in terms of delays growing less quickly with the new
 algorithm.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23816#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs