[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24174 [Metrics/ExoneraTor]: Use an embedded Jetty in ExoneraTor

#24174: Use an embedded Jetty in ExoneraTor
--------------------------------+------------------------------
 Reporter:  iwakeh              |          Owner:  iwakeh
     Type:  enhancement         |         Status:  needs_review
 Priority:  Medium              |      Milestone:
Component:  Metrics/ExoneraTor  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:  metrics-2017        |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+------------------------------
Changes (by iwakeh):

 * status:  needs_revision => needs_review


Comment:

 So, now all is available for review on
 [https://gitweb.torproject.org/user/iwakeh/exonerator.git/log/?h=task-24174
 this branch].
 I ammended the initial commit with those changes I had forgotten, as it
 wouldn't help to review the difference.  But I found some other things in
 addition, which have three more commits on their own.

 * For testing (and maybe other production server settings) we don't really
 want to query exonerator.tp.o.  Thus,
 [https://gitweb.torproject.org/user/iwakeh/exonerator.git/commit/?h=task-24174&id=02c9c5fbcc3c22545197719882bffb2e01c99bbd
 this commit] makes it configurable.
 * The tests I did with the empty db also triggered an NPE and made me
 aware of connections that could stay unclosed.  See
 [https://gitweb.torproject.org/user/iwakeh/exonerator.git/commit/?h=task-24174&id=7817a7cc2a88671882fafabff162f262adc650fa
 this commit].
 * Database credentials are set in jetty.xml, but it might be useful to
 also configure these on the command line.
 [https://gitweb.torproject.org/user/iwakeh/exonerator.git/commit/?h=task-24174&id=66cdd7eaefd99c737922205d78433c26c9c08697
 This commit] gives an example by using system properties.

 Please review again.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24174#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs