[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24269 [Core Tor/Tor]: Raise a FATAL error if the user tried to combine v2 and prop224 hidden service in same directory

#24269: Raise a FATAL error if the user tried to combine v2 and prop224 hidden
service in same directory
----------------------------+------------------------------------
 Reporter:  cypherpunks     |          Owner:  (none)
     Type:  task            |         Status:  new
 Priority:  Medium          |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  tor-hs prop224  |  Actual Points:
Parent ID:                  |         Points:  0.3
 Reviewer:                  |        Sponsor:
----------------------------+------------------------------------
Changes (by dgoulet):

 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.3.x-final


Comment:

 Ok btw, we have this in `hs_config.c`:

 {{{
   /* XXX: Validate if we have any service that has the given service dir
 path.
    * This has two problems:
    *
    * a) It's O(n^2), but the same comment from the bottom of
    *    rend_config_services() should apply.
    *
    * b) We only compare directory paths as strings, so we can't
    *    detect two distinct paths that specify the same directory
    *    (which can arise from symlinks, case-insensitivity, bind
    *    mounts, etc.).
    *
    * It also can't detect that two separate Tor instances are trying
    * to use the same HiddenServiceDir; for that, we would need a
    * lock file.  But this is enough to detect a simple mistake that
    * at least one person has actually made. */
 }}}

 So known issue but not that simple to fix.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24269#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs