[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23114 [Core Tor/Tor]: Circuit Build Timeout should apply at circuit completion
#23114: Circuit Build Timeout should apply at circuit completion
-------------------------------------------------+-------------------------
Reporter: mikeperry | Owner:
| mikeperry
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: guard-discovery-prop247-controller, | Actual Points:
review-group-25, review-group-26 |
Parent ID: #23100 | Points:
Reviewer: asn | Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):
* status: needs_review => needs_revision
Comment:
OK great mike! I'm quite happy with the current state of the code!
Two minor nitpicks and we are ready to roll:
- I find it a bit awkward that we are calculating `first_hop_succeeded`
twice in the same way both in
`circuit_build_times_mark_circ_as_measurement_only()` and in its caller
`circuit_expire_building()`. I wonder what we could do to only do the
calculation once. One solution could be to return the value of
`first_hop_succeeded` from
`circuit_build_times_mark_circ_as_measurement_only()` and use it in
`circuit_expire_building()`. Do you think that makes sense or would it be
uglier?
- Let's add a note in the function doc of `circuit_any_opened_circuits()`
that we cache its result as well.
After these two minor things are resolved, I think the next steps is to
squash everything, make a new merge request, and mark it as `merge_ready`
so that Nick can check it out.
Cheers!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23114#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs