Re: [tor-bugs] #27443 [Applications/Tor Browser]: Update Firefox RBM config and build for Android

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#27443: Update Firefox RBM config and build for Android
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-mobile,                 |  Actual Points:
  TorBrowserTeam201811                           |
Parent ID:  #26693                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 I'm excited for this!

 In `projects/firefox/mozconfig-android-armv7`
 {{{
 +mk_add_options MOZILLA_OFFICIAL=1
 }}}
 We don't need this automake directive anymore (the export replaces it)

 {{{
 +ac_add_options --with-android-version=22
 }}}
 Do we need this? We've used the default value without a problem (the
 default is 9 for 32-bit CPU archs, and 21 for 64-bit).
 {{{
 +ac_add_options --with-ccache
 }}}
 I agree with gk in comment:28 - ccache won't help us here

 In `projects/firefox/config`
 {{{
 +  android-armv7:
 +    var:
 +      arch_deps:
 +        - openjdk-8-jdk
 +        - ccache
 }}}
 nit: ccache here, too

 `projects/firefox/how-to-create-dependencies-list.txt`
 nit: can the lines be wrapped at some length? (72, 79, 80, 100?)

 In `projects/firefox/fetch-gradle-dependencies`
 {{{
 +    echo "[% artifact.sha256sum %]  downloaded_file" | sha256sum -c
 }}}
 Does the script fail when this line returns non-zero?  There's no error
 handling, so I'm guessing this is caught another way?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27443#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs