[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28096 [Core Tor/Tor]: Windows 8.1 and 10 relays claim to be Windows 8
#28096: Windows 8.1 and 10 relays claim to be Windows 8
-------------------------------------------------+-------------------------
Reporter: teor | Owner: teor
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.0.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.2.2.34
Severity: Normal | Resolution:
Keywords: windows, fast-fix, 029-backport, | Actual Points: 0.2
033-backport, 034-backport, 035-backport |
Parent ID: | Points: 0.2
Reviewer: asn | Sponsor:
-------------------------------------------------+-------------------------
Comment (by teor):
Replying to [comment:15 nickm]:
> Replying to [comment:13 teor]:
> > Replying to [comment:12 asn]:
> > > LGTM but what to do about the `TODO: only print this in the main
process on Windows,`?
> >
> > nickm will help some time this week.
>
> Okay, here's a possibility. On Windows, when tinytest relaunches itself
as a subprocess, it passes itself the --RUNNING-FORKED option. You could
check for the presence of that option in argv, and use it to decide
whether to log the version.
Ok, but:
> > 4. The parent/child flag is in tinytest.c, but the tor-specific code
is in testing_common.c. How do I get access to the parent/child flag in
testing_common.c ?
Should I pass argv (or the flag) to testing_common.c, or include tor-
specific code in tinytest.c?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28096#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs