[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25013 [Applications/Tor Browser]: Move TorButton code to the tor browser repository
#25013: Move TorButton code to the tor browser repository
-------------------------------------------------+-------------------------
Reporter: igt0 | Owner: tbb-
| team
Type: defect | Status:
| needs_review
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile, TBA-a2, | Actual Points:
TorBrowserTeam201811 |
Parent ID: #10760 | Points:
Reviewer: gk, sysrqb, mcs, | Sponsor:
-------------------------------------------------+-------------------------
Changes (by igt0):
* status: needs_revision => needs_review
Comment:
Yeah, oddly enough, the submodule was using an old git hash.
I updated the patch:
https://trac.torproject.org/projects/tor/attachment/ticket/25013/0001-Bug-25013
-Add-torbutton-as-a-tor-browser-submodule.2.patch
- Updated the submodule commit
- Added a reference to the bug #27611
Replying to [comment:62 gk]:
> Replying to [comment:61 igt0]:
> > Patch for tor browser:
> >
> >
https://trac.torproject.org/projects/tor/attachment/ticket/25013/0001-Bug-25013
-Add-torbutton-as-a-tor-browser-submodule.patch
> >
> > ** Bug 25013: Add torbutton as a tor-browser submodule**
>
> This is essentially a fix for #27611 as you seem to indicate in your
commit message? If so, lets mention that ticket there, too.
>
> The submodule commit seems wrong. I can't check Torbutton out. I guess
it should be ac8d9251494056e761bb2cf5c2a4795a888f38bd instead?
>
> s/non restartless/non-restartless/
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25013#comment:63>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs