Re: [tor-bugs] #28468 [Applications/Tor Browser]: Modify Android toolchain to support Orbot

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#28468: Modify Android toolchain to support Orbot
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-mobile, TBA-a2,         |  Actual Points:
  TorBrowserTeam201811                           |
Parent ID:  #26693                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  tbb-rbm, tbb-mobile, TBA-a2, TorBrowserTeam201811R => tbb-rbm,
     tbb-mobile, TBA-a2, TorBrowserTeam201811
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:1 sisbell]:
 > Changes (android-1115)
 >
 >  * Changed NDK version used from 26 to 16 (this is only for building of
 rust)

 You mean this is for Orbot, right? Because that's what the commit message
 says and there is no Rust involvement into building Orbot. So, I think
 commit message needs to get updated at least.

 What speaks against hardcoding "16" as you did before and just adding a
 comment in the build script explaining the situation and what we are
 doing?

 You wrote "Changed NDK version used from 26 to 16" but that's confusing to
 me. We are using NDK *r15c* for our build so far (which is why we are
 downloading only that one in the first place) so far as that is what
 Mozilla's Fennec is using and SDK 26. So, we weren't previously using
 *NDK* 26. Do you mean "SDK" here? (Looking at the NDK download page r18b
 is the highest stable you get)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28468#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs