Re: [tor-bugs] #28458 [Core Tor/sbws]: Stop resolving domains locally and check same flags for the 2nd hop

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#28458: Stop resolving domains locally and check same flags for the 2nd hop
---------------------------+--------------------------------
 Reporter:  juga           |          Owner:  juga
     Type:  defect         |         Status:  needs_revision
 Priority:  Medium         |      Milestone:
Component:  Core Tor/sbws  |        Version:  sbws: 1.0.0
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+--------------------------------
Changes (by pastly):

 * status:  needs_review => needs_revision


Comment:

 Changes requested in the PR. And now I'm going to repeat myself a bit.

 Replying to [comment:6 juga]
 > I'm running a testing instance and is being faster, failing less
 circuits.


 Okay. Let's do away with resolving domain names locally.

 All we need to do to accomplish this is give stem a `None` in place of a
 `host` when asking it to check exit policies.

 Replying to [comment:10 juga]
 >> Do we need to give it a 50% chance of being measured like a non-exit?
 > i don't understand what you mean as "non-exit", all relays are measured
 as non-exits (1st hop), the exits are chosen independently for the 2nd
 hop.

 Right now when sbws measures an exit, it tries to measure it in the 2nd
 hop position (ignoring DNS failures etc. etc)

 With your changes, all relays (exits and non-exits) are measured in the
 1st hop position. Why?


 -----

 I think there's two changes that should be made as part of this ticket,
 and somehow that's exploded into a lot of little buggy revisions.

 1. Give stem a `None` for a `host`
 2. When picking an exit helper (for measuring a non-exit or for measuring
 an exit that can't exit to our destination port, *it doesn't matter*), be
 sure to check that it's exit policy allows exiting to our destination
 port.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28458#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs