Re: [tor-bugs] #28468 [Applications/Tor Browser]: Modify Android toolchain to support Orbot

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#28468: Modify Android toolchain to support Orbot
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-mobile, TBA-a2,         |  Actual Points:
  TorBrowserTeam201811                           |
Parent ID:  #26693                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 Replying to [comment:4 gk]:


 > Okay, I chatted a bit with sysrqb and am still digging through all the
 different concepts (that seem to get used differently sometimes, too). So,
 could you say why exactly we did need to go back from `--api 26` to `--api
 16`.
 My preference is to default to higher version unless something has been
 deprecated or something bad shows up in runtime testing. I changed back to
 16 since from my understanding of the discussions that we should be more
 cautious and use what firefox is using. I see valid points for this as
 well. Honestly, I think we are ok with either version since we aren't
 using the more recent features in the NDK.
 >
 > And it seems the toolchain Mozilla uses is defining
 `-D__ANDROID_API__=9` while the `make_standalone_toolchain.py` script
 defines `-D__ANDROID_API__=$api-level` with `api-level` being the one
 passed on with `--api`.
 >
 > Interestingly enough, passing `--api 9` to the python script results in
 an error: `9 is less than minimum platform for arm (14)`. I wonder whether
 that's a shortcoming of that script which means that we actually can't
 assemble a similar toolchain to the one Mozilla uses?
 We can build firefox code with api 9 but yes it is a red flag that the
 toolchain script refuses to do this (I assume google is not being
 arbitrary on this). I don't think Mozilla is following best practices in
 all of this (partly for historical and legacy reasons).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28468#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs