Re: [tor-bugs] #28446 [Core Tor/sbws]: Change sbws scaling method to torflow

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#28446: Change sbws scaling method to torflow
---------------------------+-------------------------------------
 Reporter:  teor           |          Owner:  (none)
     Type:  defect         |         Status:  new
 Priority:  Medium         |      Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+-------------------------------------

Comment (by juga):

 Replying to [comment:2 teor]:
 > I don't think it is completely fixed, because the default is still None
 in some places:
 > https://github.com/torproject/sbws/blob/master/sbws/lib/v3bwfile.py#L461

 The default was None there, but it's being called by generate, which has
 torflow's method as default one.

 Replying to [comment:1 juga]:
 > That was fixed in
 >
 https://gitweb.torproject.org/sbws.git/commit/?id=835255703d582964a0e564d81a7848e87c5568cd,
 i forgot to remove the todo.
 >
 > I agree it's also confusing that if pass that option, it does the
 opposite, so i should change the name and/or add help text.

 I've done this in https://github.com/juga0/sbws/tree/ticket28446.

 I'm not changing this ticket to needs_review. If you're going to review
 it, let me know assigning yourself as reviewer, otherwise i'll merge and
 close in one week.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28446#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs