[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27993 [Core Tor/Tor]: craft a git pre push hook that declines to receive fixup! commits?

#27993: craft a git pre push hook that declines to receive fixup! commits?
----------------------------+------------------------------------
 Reporter:  arma            |          Owner:  (none)
     Type:  defect          |         Status:  merge_ready
 Priority:  Medium          |      Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:                  |         Points:
 Reviewer:  dgoulet         |        Sponsor:
----------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:   => dgoulet


Comment:

 This works great for me.

 After a discussion on IRC with rl1987, the changes were made that the git
 hook only considers `master`, `release-*` and `maint-*` branches. It won't
 apply to the other branches.

 I'm also fine having it named `pre-push` in `maint/` but there is also a
 possible argument to identify it has a git hook like `pre-push.git-hook`
 or something around those lines. I'll leave it to nickm to decide on that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27993#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs