[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28051 [Applications/Tor Browser]: Build Orbot into TBA
#28051: Build Orbot into TBA
-------------------------------------------------+-------------------------
Reporter: sysrqb | Owner: sysrqb
Type: enhancement | Status:
| needs_review
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile, tba-a2, | Actual Points:
TorBrowserTeam201811 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by gk):
Okay, starting to review I guess `28051_2`?
1) Can you squash those fixups you made (that is commits
43936a111d23a89d509e9de75ecf2f28c17dc3c0 and
c7fa82b84eceacf49d7d9436bfeb530630c9fd03) and base the branch on the
latest `tor-browser-60.3.0esr-8.5-1`?
2) commit ca62a15e7e8f6781c61e82c4ec64bc4fcfbfe97c
{{{
+ //implementation 'com.github.apl-devs:appintro:v4.2.2'
+ //implementation 'com.github.javiersantos:AppUpdater:2.6.4'
}}}
Let's omit those if we don't need them. The Orbot integration is already
complex enough :)
3) commit 5a755dad3b549f5e01b87016f6f4bfbfbd3654cc
I doubt we'll ever get back to a model where Tor Browser for Android ships
without Orbot or something similarly integrated and needs to ask the user
about installing Orbot first. Thus, can we clean up the
`checkStartOrbot()` related logic while we are at it instead of working
around with `checkStartOrbot2()`?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28051#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs