Re: [tor-bugs] #28051 [Applications/Tor Browser]: Build Orbot into TBA

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#28051: Build Orbot into TBA
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  sysrqb
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tba-a2,                  |  Actual Points:
  TorBrowserTeam201811                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Okay some more comments (I did not finish reviewing yet as I am fighting
 with #27977):

 a97dedfcb4830e13b1dea8625568ee1234ad9ac9 - why do we have the okhttp3.pro
 stuff and `-keepnames class org.torproject.*` is commented out? The orbot
 blame does not specify the proguard rules update either (where okhttp3.*
 etc. got added the first time). Is that due to a newer SDK supported?


 2da1ac0e6d324000373742473ed8359168310564 - why do we have
 {{{
 +                final SafeIntent intent = new SafeIntent(getIntent());
 }}}
 given that we don't seem to use that intent in the following code?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28051#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs