[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28142 [Core Tor/Tor]: Merge original WTF-PAD branch
#28142: Merge original WTF-PAD branch
-------------------------------------------------+-------------------------
Reporter: asn | Owner:
| mikeperry
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: wtf-pad, tor-relay, tor-cell, | Actual Points:
padding |
Parent ID: | Points:
Reviewer: asn | Sponsor:
| Sponsor2
-------------------------------------------------+-------------------------
Comment (by riastradh):
I attached some patches to:
- reindent the code according to my understanding of tor's indentation
style, since it had been getting a little inconsistent;
- address one of the questions in
https://github.com/torproject/tor/pull/533, and re-enable some related
tests that were mistakenly disabled;
- use separate functions for floor and ceiling instead of one with a
boolean parameter; and
- convert assert to tor_assert.
With these patches, the only remaining complaints from `make check` are:
- lines that are too long because they contain URLs that are too long; and
- includes that are not allowed because of missing .may_include or
something.
I'm not sure what the best way to address these is -- break the URLs, or
add an override; update .may_include, or move files around -- so I'll
leave that up to you folks to decide.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28142#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs