[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28051 [Applications/Tor Browser]: Build Orbot into TBA
#28051: Build Orbot into TBA
-------------------------------------------------+-------------------------
Reporter: sysrqb | Owner: sysrqb
Type: enhancement | Status:
| needs_revision
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile, tba-a2, | Actual Points:
TorBrowserTeam201811 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by sysrqb):
Replying to [comment:20 gk]:
> Okay some more comments (I did not finish reviewing yet as I am fighting
with #27977):
>
> a97dedfcb4830e13b1dea8625568ee1234ad9ac9 - why do we have the
okhttp3.pro stuff and `-keepnames class org.torproject.*` is commented
out? The orbot blame does not specify the proguard rules update either
(where okhttp3.* etc. got added the first time). Is that due to a newer
SDK supported?
>
The okhttp3 lines are needed because of how the libraries are linked and
ProGuard throws errors. I followed their official doc for this -
https://github.com/square/okhttp/blob/master/okhttp/src/main/resources
/META-INF/proguard/okhttp3.pro
I'll remove the `org.torproject.*` entry, it's not needed anymore.
>
> 2da1ac0e6d324000373742473ed8359168310564 - why do we have
> {{{
> + final SafeIntent intent = new SafeIntent(getIntent());
> }}}
> given that we don't seem to use that intent in the following code?
Indeed. I'll delete that.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28051#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs